feat(trace-handler): TracePos becomes a wrapper for u32 alias [fixes VM-267] #544

raftedproc · 2023-03-21T17:56:11Z

feat(trace-handler): TracePos becomes a wrapper for u32 alias [fixes VM-267]

linear · 2023-03-21T17:56:15Z

VM-267 Replace usize with an explicit type wrapper over u32 alias for TracePos

TracePos is a wrapper type over usize now. It must be replaced with an explicit type + u32 type alias.

coveralls · 2023-03-21T18:03:23Z

Pull Request Test Coverage Report for Build 4573995066

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

43 of 48 (89.58%) changed or added relevant lines in 12 files are covered.
45 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 83.613%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/air-lib/trace-handler/src/errors.rs	0	1	0.0%
crates/air-lib/trace-handler/src/handler.rs	5	6	83.33%
air/src/execution_step/instructions/ap/apply_to_arguments.rs	15	18	83.33%

Files with Coverage Reduction	New Missed Lines	%
crates/air-lib/trace-handler/src/handler.rs	11	86.44%
air/src/execution_step/instructions/call/prev_result_handler.rs	16	83.93%
air/src/execution_step/instructions/ap/apply_to_arguments.rs	18	82.93%

Totals
Change from base Build 4573883453:	-0.08%
Covered Lines:	15930
Relevant Lines:	19052

💛 - Coveralls

monoid · 2023-03-22T18:57:23Z

I don't think it is chore, I rather think it is feat (chore doesn't increment version).

crates/air-lib/interpreter-data/src/lib.rs

crates/air-lib/trace-handler/src/state_automata/errors.rs

air/src/execution_step/instructions/ap/apply_to_arguments.rs

air/tests/test_module/negative_tests/uncatchable_trace_related.rs

crates/air-lib/trace-handler/src/data_keeper/keeper.rs

air/src/execution_step/errors/uncatchable_errors.rs

air/src/execution_step/instructions/ap/apply_to_arguments.rs

crates/air-lib/trace-handler/src/state_automata/par_fsm/state_handler/new_states_calculation.rs

…VM-267]

monoid

utACK

raftedproc requested review from monoid and mikevoronov March 21, 2023 17:56

raftedproc changed the title ~~chore(trace-handler): TracePos becomes a wrapper for u32 alias [fixes…~~ chore(trace-handler): TracePos becomes a wrapper for u32 alias [fixes VM-267] Mar 21, 2023

raftedproc force-pushed the chore/vm-267-trace-pos branch from 012c50e to 1f8775d Compare March 22, 2023 10:27

monoid reviewed Mar 22, 2023

View reviewed changes

crates/air-lib/interpreter-data/src/lib.rs Outdated Show resolved Hide resolved

monoid reviewed Mar 22, 2023

View reviewed changes

crates/air-lib/trace-handler/src/state_automata/errors.rs Show resolved Hide resolved

raftedproc force-pushed the chore/vm-267-trace-pos branch 4 times, most recently from 4debf88 to 9e12960 Compare March 31, 2023 09:27

raftedproc changed the title ~~chore(trace-handler): TracePos becomes a wrapper for u32 alias [fixes VM-267]~~ feat(trace-handler): TracePos becomes a wrapper for u32 alias [fixes VM-267] Mar 31, 2023

raftedproc marked this pull request as ready for review March 31, 2023 09:28

raftedproc requested a review from monoid March 31, 2023 09:28